Skip to content

chore: rename recurring order FeatureId - #10631

Merged
micaelae merged 3 commits into
mainfrom
swaps-recurring-featureid
Sep 30, 2026
Merged

micaelae merged 3 commits into
mainfrom
swaps-recurring-featureid

Conversation

@micaelae

@micaelae micaelae commented Sep 30, 2026 •

Copy link
Copy Markdown
Member

Explanation

Renames the RECURRING_BUY featureId to RECURRING_ORDER. Consumers will need to update their enums and test fixtures

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Medium Risk
Breaking public enum and string identifier change; clients still using recurring_buy will fail type-checks or send mismatched analytics until updated.

Overview
Breaking rename of the bridge FeatureId used for recurring flows: the enum member becomes RECURRING_ORDER with wire value 'recurring_order' instead of RECURRING_BUY / 'recurring_buy'.

The @metamask/bridge-controller Unreleased changelog documents the breaking change. Consumers must switch enum references and any hard-coded feature_id strings (e.g. when calling fetchQuotes or emitting unified swap/bridge analytics) to the new name so attribution stays aligned with Segment conventions.

Reviewed by Cursor Bugbot for commit cfdd67e. Bugbot is set up for automated code reviews on this repo. Configure here.

@micaelae
micaelae requested review from a team as code owners September 30, 2026 18:08
@micaelae
micaelae deployed to default-branch September 30, 2026 18:08 — with GitHub Actions Active
@micaelae
micaelae enabled auto-merge September 30, 2026 18:54
@micaelae
micaelae added this pull request to the merge queue Sep 30, 2026
Merged via the queue into main with commit 13bd16c Sep 30, 2026
49 checks passed
@micaelae
micaelae deleted the swaps-recurring-featureid branch September 30, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants